Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.1k
Delay errors in semanal for proper unreachability information#20425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
A5rocks commentedDec 16, 2025
Idea for a speedup (so I don't forget): only do this for things that can be skipped unreachable (I.e. stmts in a block, toplevel stmts). Also note that I haven't cleaned this up, which would involve removing eg the |
This comment has been minimized.
This comment has been minimized.
Note that there are a few places where unreachable code can happen where this still doesn't help. I'm not sure what to do about them.
A5rocks commentedDec 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I made the changes I thought would help but this is still slow: I suppose this is just going to be slow no matter what... Second run with better stdev (still slower): |
This comment has been minimized.
This comment has been minimized.
A5rocks commentedDec 19, 2025
Now it's slightly faster: I'm going to assume that's an acceptable slowdown. If not, I'm out of ideas on how to make it faster. I still have to clean this PR up and add test cases, but I will mark it as ready for review because the logic is finished! (I haven't put aside the time to look at dmypy yet...)
|
This comment has been minimized.
This comment has been minimized.
Diff frommypy_primer, showing the effect of this PR on open source code: strawberry (https://github.com/strawberry-graphql/strawberry)+ strawberry/relay/types.py:846: error: Unused "type: ignore" comment [unused-ignore]comtypes (https://github.com/enthought/comtypes)- comtypes/test/test_server.py:326: error: Module "comtypes.gen" has no attribute "TestLib" [attr-defined]egglog-python (https://github.com/egraphs-good/egglog-python)+ python/tests/test_unstable_fn.py:177: error: Unused "type: ignore" comment [unused-ignore]Expression (https://github.com/cognitedata/Expression)- README.py:498: error: Name "z" already defined on line 496 [no-redef]- README.py:572: error: Name "z" already defined on line 570 [no-redef]- README.py:628: error: Name "xs" already defined on line 211 [no-redef]- README.py:632: error: Name "mapper" already defined on line 207 [no-redef]- README.py:633: error: Name "predicate" already defined on line 208 [no-redef]- README.py:634: error: Name "folder" already defined on line 209 [no-redef]AutoSplit (https://github.com/Toufool/AutoSplit)- src/utils.py:147:12: error: Name "win32ui" is not defined [name-defined]- src/utils.py:155:29: error: Name "ctypes" is not defined [name-defined]- src/utils.py:156:5: error: Name "ctypes" is not defined [name-defined]- src/utils.py:159:9: error: Name "ctypes" is not defined [name-defined]- src/utils.py:160:9: error: Name "ctypes" is not defined [name-defined]- src/utils.py:163:19: error: Name "win32gui" is not defined [name-defined]- src/utils.py:176:20: error: Name "FilterGraph" is not defined [name-defined]- src/utils.py:182:12: error: Name "COMError" is not defined [name-defined] |
Uh oh!
There was an error while loading.Please reload this page.
return#14940This is a draft PR because: