Commite69af83

authored

Allowtypes.NoneType in match cases (#20383)

1 parent488f3c7 commite69af83Copy full SHA for e69af83

File tree

+19

-0

lines changed

+19

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@`
`46`	`46`	`Type,`
`47`	`47`	`TypedDictType,`
`48`	`48`	`TypeOfAny,`
	`49`	`+TypeType,`
`49`	`50`	`TypeVarTupleType,`
`50`	`51`	`TypeVarType,`
`51`	`52`	`UninhabitedType,`
`@@ -556,6 +557,8 @@ def visit_class_pattern(self, o: ClassPattern) -> PatternType:`
`556`	`557`	`fallback=self.chk.named_type("builtins.function")`
`557`	`558`	`any_type=AnyType(TypeOfAny.unannotated)`
`558`	`559`	`typ=callable_with_ellipsis(any_type,ret_type=any_type,fallback=fallback)`
	`560`	`+elifisinstance(p_typ,TypeType)andisinstance(p_typ.item,NoneType):`
	`561`	`+typ=p_typ.item`
`559`	`562`	`elifnotisinstance(p_typ,AnyType):`
`560`	`563`	`self.msg.fail(`
`561`	`564`	`message_registry.CLASS_PATTERN_TYPE_REQUIRED.format(`

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3178,3 +3178,19 @@ match 5:`
`3178`	`3178`	`reveal_type(b) # N: Revealed type is "Any"`
`3179`	`3179`	`case BlahBlah(c=c): # E: Name "BlahBlah" is not defined`
`3180`	`3180`	`reveal_type(c) # N: Revealed type is "Any"`
	`3181`	`+`
	`3182`	`+[case testMatchAllowsNoneTypeAsClass]`
	`3183`	`+import types`
	`3184`	`+`
	`3185`	`+class V:`
	`3186`	`+ X = types.NoneType`
	`3187`	`+`
	`3188`	`+def fun(val: str \| None):`
	`3189`	`+ match val:`
	`3190`	`+ case V.X():`
	`3191`	`+ reveal_type(val) # N: Revealed type is "None"`
	`3192`	`+`
	`3193`	`+ match val:`
	`3194`	`+ case types.NoneType():`
	`3195`	`+ reveal_type(val) # N: Revealed type is "None"`
	`3196`	`+[builtins fixtures/tuple.pyi]`

Comments

(0)