Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-29711: Fix stop_serving in proactor loop kill all listening servers#431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
1st1 merged 1 commit intopython:masterfromjulien-duponchelle:fix-issue-29711
Dec 19, 2017

Conversation

julien-duponchelle
Copy link
Contributor

@julien-duponchellejulien-duponchelle commentedMar 3, 2017•
edited by bedevere-bot
Loading

Current implementation of the asyncio Proactor event loop has an issue, when you stop a server it's cancel the futures of all other servers.

Original discussion:python/asyncio#496

https://bugs.python.org/issue29711

@mention-bot
Copy link

@noplay, thanks for your PR! By analyzing the history of the files in this pull request, we identified@Haypo and@1st1 to be potential reviewers.

@1st1
Copy link
Member

1st1 commentedMar 3, 2017

@Haypo Can you take a look at this PR?

@julien-duponchelle
Copy link
ContributorAuthor

Can I do something to help ?

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@vstinner
Copy link
Member

I agree that it's plain wrong to cancel the "accept future" ofall listening servers.

@1st1
Copy link
Member

Could you please add a NEWS entry using blurb?

@1st11st1 requested a review fromasvetlovOctober 19, 2017 17:35
@asvetlov
Copy link
Contributor

@noplay ping

@julien-duponchelle
Copy link
ContributorAuthor

News entry added

@1st1
Copy link
Member

Could you please rebase your PR once again?

@julien-duponchelle
Copy link
ContributorAuthor

It's rebase

@1st11st1 merged commit319c034 intopython:masterDec 19, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@1st11st11st1 approved these changes

@asvetlovasvetlovAwaiting requested review from asvetlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@julien-duponchelle@mention-bot@1st1@vstinner@asvetlov@the-knights-who-say-ni@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp