Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-136186: Fix flaky tests in test_external_inspection#143110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Several tests calling unwinder.get_stack_trace() were flaky because theyused retry loops without exception handling. Transient failures like"Failed to parse initial frame in chain" that occur when sampling at aninopportune moment would immediately fail the test instead of beingretried.The fix adds a _get_stack_trace_with_retry helper function and updatesseven locations to use busy_retry with contextlib.suppress for OSErrorand RuntimeError, matching the existing pattern in_get_frames_with_retry. This allows transient failures to be silentlyretried while still timing out if the expected condition is never met.
bedevere-bot commentedDec 23, 2025
🤖 New build scheduled with the buildbot fleet by@pablogsal for commit9309fbc 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143110%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
bedevere-bot commentedDec 23, 2025
🤖 New build scheduled with the buildbot fleet by@pablogsal for commit0d68f47 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143110%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
bedevere-bot commentedDec 23, 2025
🤖 New build scheduled with the buildbot fleet by@pablogsal for commit48cba1f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143110%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
Uh oh!
There was an error while loading.Please reload this page.
Several tests calling unwinder.get_stack_trace() were flaky because they
used retry loops without exception handling. Transient failures like
"Failed to parse initial frame in chain" that occur when sampling at an
inopportune moment would immediately fail the test instead of being
retried.
The fix adds a _get_stack_trace_with_retry helper function and updates
seven locations to use busy_retry with contextlib.suppress for OSError
and RuntimeError, matching the existing pattern in
_get_frames_with_retry. This allows transient failures to be silently
retried while still timing out if the expected condition is never met.