Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-141004: DocumentPyFile_OpenCode andPyFile_OpenCodeObject#141413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Doc/c-api/file.rst Outdated
| :c:expr:`const char*` that is decoded by the | ||
| :term:`filesystem encoding and error handler`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
UTF-8 encoding, no (also implied by the parameter name)?
Line 528 ind890aba
| PyObject*pathobj=PyUnicode_FromString(utf8path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, good catch.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
2befce8 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…t` (pythonGH-141413)(cherry picked from commit2befce8)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
GH-141425 is a backport of this pull request to the3.14 branch. |
…t` (pythonGH-141413)(cherry picked from commit2befce8)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
GH-141426 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--141413.org.readthedocs.build/en/141413/c-api/file.html#c.PyFile_OpenCodeObject