Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
Add regression test for PySet_Contains#141411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Carreau wants to merge1 commit intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+63 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
python-cla-botbot commentedNov 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
As discussed inpythongh-141183, the test suite did nottest that PySet_Contains does not convert unhashable keyinto a frozenset.This commit adds a regression test for thisbehavior, to ensure that any behavior change iscaught by the test suite.
3434a3d to9d02192Compare| staticPyObject* | ||
| test_set_contains_does_not_convert_unhashable_key(PyObject*self,PyObject*Py_UNUSED(obj)) | ||
| { | ||
| // The documentation of PySet_Contains state: |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can just add a link to docs, the code is self-explanatory of the behavior.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed ingh-141183, the test suite did not
test that
PySet_Containsdoes not convert unhashable key into a frozenset.This commit adds a regression test for this
behavior, to ensure that any behavior change is
caught by the test suite.
--
I'm not sure opening a GitHub issue, or having a blurb is necessary as this only adds a test.
Here is thelink to the comment where@kumaraditya303 suggested for me to send a test as a separate PR.