Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-141376: make smelly: Add colours, adjust messages.#141394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
encukou commentedNov 11, 2025
@AA-Turner@hugovk How can I inform precommit that |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Instead of colors, I would prefer to not print each tested binary unless if has "smelly" symbols.
hugovk commentedNov 11, 2025
Add this to diff --git a/Tools/build/.ruff.toml b/Tools/build/.ruff.tomlindex 996f725fdcb..e7852abe131 100644--- a/Tools/build/.ruff.toml+++ b/Tools/build/.ruff.toml@@ -31,6 +31,9 @@ ignore = [ "PYI025", # Use `from collections.abc import Set as AbstractSet` ]+[lint.isort]+extra-standard-library = ["_colorize"]+ [lint.per-file-ignores] "{check_extension_modules,freeze_modules}.py" = [ "UP031", # Use format specifiers instead of percent format Docs:https://docs.astral.sh/ruff/settings/#lint_isort_extra-standard-library And note it'll stick it first in the stdlib import list. |
encukou commentedNov 11, 2025
@hugovk, thanks! Maybe I'll not need it here but hopefully I'll remember next time. @vstinner, would you be OK with something likehttps://github.com/encukou/cpython/blob/make-smelly-refactor/Tools/build/smelly.py ? |
vstinner commentedNov 11, 2025
Yes, something like that 👍 |
Uh oh!
There was an error while loading.Please reload this page.
Without colours, the script's output hard to scan for my spoiled eyes.
The messages are adjusted to no longer imply a lack of exceptions to the rules.
(This PR is not tightly related to#141376 but I think it's best to attach it to that issue.)