_io module: add "Py" prefix to "spec" variables. For example, rename bufferedrandom_spec to _Py_bufferedrandom_spec.
typevarobject.c: add "static" to "spec" and "slots" variables.
import.c: add "static" to "pkgcontext" variable.

Issue:[C API] Python exports symbols withoutPy prefix #141376

pythongh-141376: Fix exported symbols

24e15d9

* _io module: add "_Py_" prefix to "spec" variables. For example,  rename bufferedrandom_spec to _Py_bufferedrandom_spec.* typevarobject.c: add "static" to "spec" and "slots" variables.* import.c: add "static" to "pkgcontext" variable.

vstinner requested review fromJelleZijlstra,brettcannon,ericsnowcurrently,kumaraditya303,ncoghlan andwarsaw ascode owners

November 10, 2025 21:03

vstinner added the skip news label

Nov 10, 2025

bedevere-appbot added the awaiting core review label

Nov 10, 2025

bedevere-appbot mentioned this pull request

Nov 10, 2025

[C API] Python exports symbols withoutPy prefix#141376

Open

No longer export textiowrapper_slots

52c0d69

Copy link

MemberAuthor

vstinner commentedNov 10, 2025

With this patch:

diff --git a/Tools/build/smelly.py b/Tools/build/smelly.pyindex 9a360412a73..0b694392583 100755--- a/Tools/build/smelly.py+++ b/Tools/build/smelly.py@@ -37,7 +37,7 @@ def is_local_symbol_type(symtype):     # Ignore the initialized data section (d and D) and the BSS data     # section. For example, ignore "__bss_start (type: B)"     # and "_edata (type: D)".-    if symtype in "bBdD":+    if symtype in "bB":         return True      return False

make smelly detects fixed export issues, but also this symbol:

+ nm --no-sort libpython3.15d.aIgnore 15820 local symbolsSmelly symbol: _AsyncioDebug (type: D)ERROR: Found 1 smelly symbols!

JelleZijlstra approved these changes

Nov 10, 2025

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels

Nov 10, 2025

cmaloney approved these changes

Nov 10, 2025

View reviewed changes

Copy link

Contributor

cmaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Most modules don't need theextern PyType_Spec pieces that the_io module currently uses; 👍 for this change and I added to my I/O rework notes that it would be nice to reduce the need for these.