Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-140824: Implement the math package in Python#141363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
vstinner wants to merge11 commits intopython:main
base:main
Choose a base branch
Loading
fromvstinner:_math

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedNov 10, 2025•
edited by bedevere-appbot
Loading

Rename the 'math' extension to '_math'.

Rename the 'math' extension to '_math'.
Comment on lines +7 to +8
# gh-140824: Fix module name for pickle
defpatch_module(objs,module):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would it be better just to have the module name asmath.integer for these functions in C?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In C,function.__module__ is set to the extension name: so set to_math or_math_integer. The whole purpose of this PR is to fixfunction.__module__.

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@vstinnervstinner requested a review froma team as acode ownerNovember 10, 2025 16:16
vstinnerand others added4 commitsNovember 10, 2025 17:19
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@vstinner
Copy link
MemberAuthor

@AA-Turner: I addressed your review. Please review the updated PR.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is still a hack. I think there should be more straightforward way.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@AA-TurnerAA-TurnerAA-Turner requested changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@serhiy-storchaka@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp