Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-62480: De-personalize "Partial mocking" section inunittest.mock examples#141321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
CAM-Gerlach merged 6 commits intopython:mainfromKarnbirKhera:patch-1
Nov 9, 2025

Conversation

@KarnbirKhera
Copy link
Contributor

@KarnbirKheraKarnbirKhera commentedNov 9, 2025•
edited by github-actionsbot
Loading

Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead.

📚 Documentation preview 📚:https://cpython-previews--141321.org.readthedocs.build/

Some of the descriptions were addressed in first person, but have now been changed to address the user reading the documentation instead.
@python-cla-bot
Copy link

python-cla-botbot commentedNov 9, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-appbedevere-appbot added awaiting review docsDocumentation in the Doc dir skip news labelsNov 9, 2025
@CAM-GerlachCAM-Gerlach self-requested a reviewNovember 9, 2025 23:01
@CAM-GerlachCAM-Gerlach self-assigned thisNov 9, 2025
@CAM-GerlachCAM-Gerlach changed the titleGH-62480: Refining some wording in unittest partial mock docGH-62480: Refine some wording in unittest partial mock docNov 9, 2025
@CAM-GerlachCAM-Gerlach changed the titleGH-62480: Refine some wording in unittest partial mock docGH-62480: Avoid first person in unittest partial mock docNov 9, 2025
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Some further textual refinements, otherwise LGTM

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@CAM-GerlachCAM-Gerlach added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsNov 9, 2025
KarnbirKheraand others added5 commitsNovember 9, 2025 15:09
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
ContributorAuthor

@KarnbirKheraKarnbirKhera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes make the document more accurate. Added to original request.

@picnixzpicnixz changed the titleGH-62480: Avoid first person in unittest partial mock docgh-62480: De-personalize "Partial mocking" section inunittest.mock examplesNov 9, 2025
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM now, thanks@KarnbirKhera !

@CAM-GerlachCAM-Gerlach merged commitb618731 intopython:mainNov 9, 2025
31 of 32 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsNov 9, 2025
@miss-islington-app
Copy link

Thanks@KarnbirKhera for the PR, and@CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 9, 2025
….mock` examples (pythonGH-141321)* Refine some wording in unittest partial mock docSome of the descriptions were addressed in first person,but have now been changed to address the user reading the documentation instead.(cherry picked from commitb618731)Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-app
Copy link

GH-141326 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelNov 9, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 9, 2025
….mock` examples (pythonGH-141321)* Refine some wording in unittest partial mock docSome of the descriptions were addressed in first person,but have now been changed to address the user reading the documentation instead.(cherry picked from commitb618731)Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-app
Copy link

GH-141327 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 9, 2025
CAM-Gerlach added a commit that referenced this pull requestNov 10, 2025
…t.mock` examples (GH-141321) (#141327)gh-62480: De-personalize "Partial mocking" section in `unittest.mock` examples (GH-141321)* Refine some wording in unittest partial mock docSome of the descriptions were addressed in first person,but have now been changed to address the user reading the documentation instead.(cherry picked from commitb618731)Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach added a commit that referenced this pull requestNov 10, 2025
…t.mock` examples (GH-141321) (#141326)gh-62480: De-personalize "Partial mocking" section in `unittest.mock` examples (GH-141321)* Refine some wording in unittest partial mock docSome of the descriptions were addressed in first person,but have now been changed to address the user reading the documentation instead.(cherry picked from commitb618731)Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes

Assignees

@CAM-GerlachCAM-Gerlach

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KarnbirKhera@CAM-Gerlach
[8]ページ先頭
©2009-2025 Movatter.jp