NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

gh-141004: Document`PyFunction_SetKwDefaults`#141294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ZeroIntensity merged 2 commits intopython:mainfromZeroIntensity:document-set-kw-defaults

Nov 9, 2025

Merged

gh-141004: Document`PyFunction_SetKwDefaults`#141294

ZeroIntensity merged 2 commits intopython:mainfromZeroIntensity:document-set-kw-defaults

Nov 9, 2025

+9 −0

Conversation

Copy link

Member

ZeroIntensity commentedNov 9, 2025•
edited
Loading

Issue:Document the entire C API #141004

📚 Documentation preview 📚:https://cpython-previews--141294.org.readthedocs.build/en/141294/c-api/function.html#c.PyFunction_SetKwDefaults

Document PyFunction_SetKwDefaults().

e4698e1

ZeroIntensity added needs backport to 3.13

bugs and security fixes

needs backport to 3.14bugs and security fixes labels

Nov 9, 2025

bedevere-appbot added awaiting core review docs

Documentation in the Doc dir

skip news labels

Nov 9, 2025

github-project-automationbot added this toDocs PRs

Nov 9, 2025

github-project-automationbot moved this toTodo inDocs PRs

Nov 9, 2025

bedevere-appbot mentioned this pull request

Nov 9, 2025

Document the entire C API#141004

Open

StanFromIreland reviewed

Nov 9, 2025

View reviewed changes

Doc/c-api/function.rst OutdatedShow resolvedHide resolved

Doc/c-api/function.rstShow resolvedHide resolved

This is a setter, not a getter.

bdbc304

I'm sleepy.

StanFromIreland reviewed

Nov 9, 2025

View reviewed changes

Doc/c-api/function.rst

Comment on lines +107 to +108

		Set the keyword-only argument default values of the function object op.
		defaults must be a dictionary of keyword-only arguments or ``Py_None``.

Copy link

Member

StanFromIrelandNov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	Set the keyword-onlyargument default values of the function object op.
	defaults must be a dictionary of keyword-onlyarguments or ``Py_None``.
	Set the keyword-onlyparameter default values of the function object op.
	defaults must be a dictionary of keyword-onlyparameters or ``Py_None``.

Copy link

MemberAuthor

ZeroIntensityNov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We say "argument" everywhere else in this file, so I'd rather not deviate from it here. I don't think that the distinction is particularly helpful for readers here.

Copy link

Member

StanFromIrelandNov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not a fan of such a precedent, but unfortunately it is. Fixing this is tracked in#133438.

StanFromIreland approved these changes

Nov 9, 2025

View reviewed changes

Copy link

Member

StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

ZeroIntensity merged commit18529b5 intopython:main

Nov 9, 2025

28 checks passed

ZeroIntensity deleted the document-set-kw-defaults branch

November 9, 2025 17:49

github-project-automationbot moved this fromTodo toDone inDocs PRs

Nov 9, 2025

Copy link

miss-islington-appbot commentedNov 9, 2025

Thanks@ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting core review label

Nov 9, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 9, 2025

pythongh-141004: DocumentPyFunction_SetKwDefaults(pythonGH-141294)

cd60b7d

(cherry picked from commit 18529b580b59b8d075641da6c685bef377eb0a7b)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

Copy link

bedevere-appbot commentedNov 9, 2025

GH-141304 is a backport of this pull request to the3.14 branch.

bedevere-appbot removed the needs backport to 3.14bugs and security fixes label

Nov 9, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 9, 2025

pythongh-141004: DocumentPyFunction_SetKwDefaults(pythonGH-141294)

502fdd1

(cherry picked from commit18529b5)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

Copy link

bedevere-appbot commentedNov 9, 2025

GH-141305 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

Nov 9, 2025

ZeroIntensity added a commit that referenced this pull request

Nov 9, 2025

[3.13]gh-141004: DocumentPyFunction_SetKwDefaults(GH-141294) (GH…

aa2c8ea

…-141305)gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294)(cherry picked from commit18529b5)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

ZeroIntensity added a commit that referenced this pull request

Nov 9, 2025

[3.14]gh-141004: DocumentPyFunction_SetKwDefaults(GH-141294) (GH…

8682465

…-141304)gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294)(cherry picked from commit18529b5)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

Labels

docs

Documentation in the Doc dir

skip news

	Set the keyword-onlyargument default values of the function object op.
	defaults must be a dictionary of keyword-onlyarguments or ``Py_None``.
	Set the keyword-onlyparameter default values of the function object op.
	defaults must be a dictionary of keyword-onlyparameters or ``Py_None``.

Movatterモバイル変換

Uh oh!

gh-141004: DocumentPyFunction_SetKwDefaults#141294

gh-141004: DocumentPyFunction_SetKwDefaults#141294

Conversation

ZeroIntensity commentedNov 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StanFromIrelandNov 9, 2025

Choose a reason for hiding this comment

Uh oh!

ZeroIntensityNov 9, 2025

Choose a reason for hiding this comment

Uh oh!

StanFromIrelandNov 9, 2025

Choose a reason for hiding this comment

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-appbot commentedNov 9, 2025

Uh oh!

bedevere-appbot commentedNov 9, 2025

Uh oh!

bedevere-appbot commentedNov 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gh-141004: Document`PyFunction_SetKwDefaults`#141294

gh-141004: Document`PyFunction_SetKwDefaults`#141294

ZeroIntensity commentedNov 9, 2025•
edited
Loading