Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
Remove redundant line in test_decimal#141281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
picnixz commentedNov 9, 2025
Usually, we don't accept PRs that are only cosmetic, especially in tests. So I won't approve this one, sorry. We can clean it up if we were to rewrite To save a few keystrokes. In this case, why not having a method for that on the test class itself. Now, I would be more interested in reorganizing this test file because it's 6 THOUSANDS lines... |
efimov-mikhail commentedNov 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ok, no problems.
I agree, that's a lot of code. I've tried to make this reorganization. Maybe you have some idea on that topic? |
picnixz commentedNov 9, 2025 • edited by efimov-mikhail
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by efimov-mikhail
Uh oh!
There was an error while loading.Please reload this page.
Ithink it's fine. We already do this for |
efimov-mikhail commentedNov 9, 2025
Could you please guide me a little? |
picnixz commentedNov 9, 2025 • edited by efimov-mikhail
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by efimov-mikhail
Uh oh!
There was an error while loading.Please reload this page.
FTR, this was just for the from .importload_testsimportunittestunittest.main() and in I don't really know whether it's possible to do it though. Maybe it's not! However, I think we should discuss this either on Discord or create an issue for that (at least this PR shouldn't be used for discussion). |
No description provided.