Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-87710: Update mime type for.ai#141239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
StanFromIreland wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromStanFromIreland:a-different-kind-of-ai

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commentedNov 8, 2025•
edited by bedevere-appbot
Loading

cmaloney
cmaloney previously approved these changesNov 9, 2025
'.so' :'application/octet-stream',
'.oda' :'application/oda',
'.ogx' :'application/ogg',
'.ai' :'application/pdf',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the.pdf should go first here, from the comment:

# Make sure the entry with the preferred file extension for a particular mime type# appears before any others of the same mimetype.

Copy link
Member

@bitdancerbitdancerNov 9, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ideally we'd add a test that .pdf is returned as the preferred extension for application/pdf.

'.so' :'application/octet-stream',
'.oda' :'application/oda',
'.ogx' :'application/ogg',
'.ai' :'application/pdf',
Copy link
Member

@bitdancerbitdancerNov 9, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ideally we'd add a test that .pdf is returned as the preferred extension for application/pdf.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cmaloneycmaloneycmaloney left review comments

@bitdancerbitdancerbitdancer requested changes

@hugovkhugovkAwaiting requested review from hugovk

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@bitdancer@cmaloney
[8]ページ先頭
©2009-2025 Movatter.jp