Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-140939: Fix memory leak in_PyBytes_FormatEx error path#140957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 5 commits intopython:mainfromStanFromIreland:bytes-leak
Nov 6, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commentedNov 3, 2025
edited by bedevere-appbot
Loading

It is already accounted for in the other path:

if (dict&& (argidx<arglen)) {
PyErr_SetString(PyExc_TypeError,
"not all arguments converted during bytes formatting");
Py_XDECREF(temp);
gotoerror;
}

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@kumaraditya303kumaraditya303 added type-bugAn unexpected behavior, bug, or error needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsNov 6, 2025
@kumaraditya303kumaraditya303 merged commitd6c89a2 intopython:mainNov 6, 2025
56 checks passed
@miss-islington-app
Copy link

Thanks@StanFromIreland for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@StanFromIreland and@kumaraditya303, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.14

@miss-islington-app
Copy link

Sorry,@StanFromIreland and@kumaraditya303, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.13

@StanFromIrelandStanFromIreland deleted the bytes-leak branchNovember 6, 2025 07:22
@StanFromIreland
Copy link
MemberAuthor

I can backport.

vstinner reacted with thumbs up emoji

@StanFromIrelandStanFromIreland self-assigned thisNov 6, 2025
@bedevere-app
Copy link

GH-141154 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelNov 6, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull requestNov 6, 2025
…path (pythonGH-140957)(cherry picked from commitd6c89a2)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull requestNov 6, 2025
…path (pythonGH-140957)(cherry picked from commitd6c89a2)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

GH-141155 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 6, 2025
vstinner pushed a commit that referenced this pull requestNov 6, 2025
vstinner pushed a commit that referenced this pull requestNov 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

+1 more reviewer

@RenaudBernierRenaudBernierRenaudBernier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StanFromIrelandStanFromIreland

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@vstinner@kumaraditya303@RenaudBernier

[8]ページ先頭

©2009-2025 Movatter.jp