Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-140260: Fix data race in _struct module initialization with subinterpreters#140909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ashm-dev wants to merge18 commits intopython:mainChoose a base branch fromashm-dev:tsan
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+66 −41
Open
Changes from1 commit
Commits
Show all changes
18 commits Select commitHold shift + click to select a range
243b5f0 Fix data race in _struct module endian table initialization
ashm-dev4c9892e fix doc
ashm-dev95958e8 refactor(c-analyzer): add endian_tables_init_once to globals-to-fix list
ashm-dev3130512 Use Py_UNUSED for unused arg in init_endian_tables
ashm-devd33514b fix: remove duplicate include of pycore_lock.h in _struct.c
ashm-devc4f577f add test
ashm-dev238c40e Remove return check for endian table init
ashm-devf4d24ff Use InterpreterPoolExecutor in struct tests
ashm-dev2977abf Ignore return value of _PyOnceFlag_CallOnce
ashm-dev5e6b45b Move endian_tables_init_once to ignored.tsv
ashm-dev4492520 Import InterpreterPoolExecutor locally in test
ashm-deva1caec9 Skip subinterpreter init test unless GIL disabled
ashm-devf1cf169 Inline exec and wrap skipUnless args
ashm-dev1408896 Skip test when InterpreterPoolExecutor missing
ashm-dev359ae9a Fix executor.map usage in test_struct
ashm-dev47494a4 Pass exec to executor.map
ashm-dev93830ea Merge branch 'main' into tsan
ZeroIntensity434dbab Merge branch 'main' into tsan
kumaraditya303File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Use Py_UNUSED for unused arg in init_endian_tables
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit3130512dbb51d37de1f5e64bb26bd70a9fc2f50c
There are no files selected for viewing
4 changes: 1 addition & 3 deletionsModules/_struct.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.