Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-139741: Makedist-pdf docs archive build work for macOS#140837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 3 commits intopython:mainfromNaitreey:fix-dist-pdf-mac
Nov 8, 2025

Conversation

@Naitreey
Copy link
Contributor

@NaitreeyNaitreey commentedOct 31, 2025•
edited by github-actionsbot
Loading

Building docs archive in pdf format on macOS is currently unsuccessful. This PR fixes it.

Changes:

  • Remove--output-sync on macOS, as macOS'smake does not yet support the output sync feature.
  • macOS doesn't havenproc by default; usegetconf _NPROCESSORS_ONLN instead.

Thanks@m-aciek for providing the initial solution and PR suggestion.

📚 Documentation preview 📚:https://cpython-previews--140837.org.readthedocs.build/

Copy link
Contributor

@m-aciekm-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Confirming it works on MacOS 26.0.1, thank you, sharing one concern

``getconf _NPROCESSORS_ONLN`` is available in both Linux and macOS, but``nproc`` is not. This change prevents the build from breaking again ifmacOS ever upgrades its `make` to version 4 or above.
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, confirmed this is working* on macOS.

* I don't have latexmk installed, but the commands are being called as expected.

m-aciek and Naitreey reacted with thumbs up emoji
@hugovkhugovk merged commit9c39946 intopython:mainNov 8, 2025
32 checks passed
@hugovkhugovk added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsNov 8, 2025
@miss-islington-app
Copy link

Thanks@Naitreey for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@Naitreey for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 8, 2025
…ythonGH-140837)(cherry picked from commit9c39946)Co-authored-by: Naitree Zhu <Naitreey@gmail.com>
@bedevere-app
Copy link

GH-141229 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelNov 8, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 8, 2025
…ythonGH-140837)(cherry picked from commit9c39946)Co-authored-by: Naitree Zhu <Naitreey@gmail.com>
@bedevere-app
Copy link

GH-141230 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 8, 2025
hugovk pushed a commit that referenced this pull requestNov 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

+1 more reviewer

@m-aciekm-aciekm-aciek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Naitreey@hugovk@m-aciek@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp