Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-139707: Add docs for optional modules#140171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 19 commits intopython:mainfromencukou:optional-module-docs
Nov 6, 2025

Conversation

@encukou
Copy link
Member

@encukouencukou commentedOct 15, 2025•
edited by github-actionsbot
Loading

... And add Stan as contributor:Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland
Copy link
Member

pre-commit install is handy :-)

encukouand others added4 commitsOctober 22, 2025 16:13
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
encukouand others added2 commitsOctober 23, 2025 09:03
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

* configuration, browsers, and other dialogs

..include::../includes/optional-module.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is the appropriate place for this, rather than buried in the idlelib entry at the end. Possible suggestion to make the include fit even better.

Suggested change
..include::../includes/optional-module.rst
The IDLE application is implemented in the idlelib package.
..include::../includes/optional-module.rst

withidlelib linked to the entry at the end of the file. OR I could do in a separate PR.

I am also considering adding ":mod:idlelib and " to the beginning of the title in a separate issue. Would have to look at the result, including indexing.

encukou reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! I added this suggestion.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Two little nits, otherwise LGTM.

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@encukouencukou merged commitd2ce6d7 intopython:mainNov 6, 2025
28 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsNov 6, 2025
@encukouencukou deleted the optional-module-docs branchNovember 6, 2025 10:49
@encukouencukou added the needs backport to 3.14bugs and security fixes labelNov 6, 2025
@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@encukou, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d2ce6d708a9eaac4e546744ca4da359ee6901ebc 3.14

@bedevere-app
Copy link

GH-141204 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelNov 7, 2025
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull requestNov 7, 2025
(cherry picked from commitd2ce6d7)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Emma Smith <emma@emmatyping.dev>Co-authored-by: Author: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments

@terryjreedyterryjreedyterryjreedy left review comments

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@vstinnervstinnervstinner approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@pfmoorepfmooreAwaiting requested review from pfmoorepfmoore is a code owner

@pradyunsgpradyunsgAwaiting requested review from pradyunsgpradyunsg is a code owner

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

@picnixzpicnixzAwaiting requested review from picnixzpicnixz is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner

+1 more reviewer

@ShakacroShakacroShakacro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@encukouencukou

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@encukou@StanFromIreland@vstinner@hugovk@emmatyping@terryjreedy@ZeroIntensity@Shakacro
[8]ページ先頭
©2009-2025 Movatter.jp