NotificationsYou must be signed in to change notification settings
Fork32.2k
Star67.7k

gh-136087: Remove`\r` from documented`os.linesep` values#136088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

sobolevn wants to merge1 commit intopython:main

base:main

Choose a base branch

fromsobolevn:issue-136087

Open

gh-136087: Remove`\r` from documented`os.linesep` values#136088

sobolevn wants to merge1 commit intopython:mainfromsobolevn:issue-136087

+1 −1

Conversation

Copy link

Member

sobolevn commentedJun 29, 2025•
edited by bedevere-appbot
Loading

Issue:Outdatedos.linesep docs inos.py #136087

pythongh-136087: Remove\rfrom documentedos.linesepvalues

5e712b8

sobolevn requested a review frompicnixz

June 29, 2025 04:48

sobolevn added the skip news label

Jun 29, 2025

bedevere-appbot added the awaiting core review label

Jun 29, 2025

bedevere-appbot mentioned this pull request

Jun 29, 2025

Outdatedos.linesep docs inos.py#136087

Open

Copy link

Contributor

collinfunk commentedJun 29, 2025

Hi, I looked into this a bit.

The value\r used to exist when the variable was added ine9387ea.

It was removed ineca20b6. It was a merge from subversion, but I am 99% percent confident it was a part of this change:

      r63158 | ronald.oussoren | 2008-05-12 07:24:33 -0400 (Mon, 12 May 2008) | 5 lines          Remove references to platform 'mac'          The 'mac' platform (that is, os.name == 'mac') was used for the MacOS 9 port,      which is no longer supported (as of Python 2.4 IIRC).

Wikipedia states that\r was used in Classic Mac OS to represent a newline [1]. The page for Classic Mac OS says Mac OS 9 was the last version. This matches with the subversion commit message.

Therefore, your patch is correct. Good catch!

[1]https://en.wikipedia.org/wiki/Newline#Representation
[2]https://en.wikipedia.org/wiki/Classic_Mac_OS