Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-131885: update documented signatures forcsv.{writer,reader}#136085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
…sv.writer` have some positional-only arguments```pythonimport csvwith open("example.csv", "w", newline='') as csvfile: csv.writer(csvfile=csvfile) # TypeError: expected at least 1 argument, got 0``````pythonimport csvcsv.reader(csvfile="a") # TypeError: expected at least 1 argument, got 0```There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Reading the source, I was a little confused at first:
Lines 1090 to 1100 inbd928a3
| if (!PyArg_UnpackTuple(args,"reader",1,2,&iterator,&dialect)) { | |
| Py_DECREF(self); | |
| returnNULL; | |
| } | |
| self->input_iter=PyObject_GetIter(iterator); | |
| if (self->input_iter==NULL) { | |
| Py_DECREF(self); | |
| returnNULL; | |
| } | |
| self->dialect= (DialectObj*)_call_dialect(module_state,dialect, | |
| keyword_args); |
PyArg_UnpackTuple unpacks positional arguments, so I would have thought thatcsv.writer(file, dialect="...") wouldn't work, but the catch is that_call_dialect checks if the dialect was non-NULL, and extracts it from the keywords if it is. But, there's nothing similar forcsvfile, so this is the correct description for the docs.
csv.reader and `csv.wri…csv.{writer,reader}
Uh oh!
There was an error while loading.Please reload this page.
…ter` have some positional-only arguments
*and/as needed #131885📚 Documentation preview 📚:https://cpython-previews--136085.org.readthedocs.build/