Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-135993: Fix IPv6 bug inset_ok_port andreturn_ok_port#136076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
LamentXU123 wants to merge12 commits intopython:main
base:main
Choose a base branch
Loading
fromLamentXU123:Fix-IPv6-bug-in-set&return-port-ok

Conversation

LamentXU123
Copy link
Contributor

@LamentXU123LamentXU123 commentedJun 28, 2025
edited
Loading

Yet another IPv6 bug fix.

Instead of using the helper functions here, I've found a regex in the code, it looks like this:

cut_port_re=re.compile(r":\d+$",re.ASCII)

This could perfectly solve the bug. caz currently, we are doing this:

defrequest_port(request):host=request.hosti=host.find(':')ifi>=0:port=host[i+1:]try:int(port)exceptValueError:_debug("nonnumeric port: '%s'",port)returnNoneelse:port=DEFAULT_HTTP_PORTreturnport

And the problem is if the input is IPv6 addr like[::1]:1234, the program will treat:1]:1234 as a port and raise a ValueError when trying toint() it.

Now, since we've got the regex, we could use it directly in this func to make sure that port numberscan only be numbers and fix the bug.

Something like this:

defrequest_port(request):match=cut_port_re.search(request.host)ifmatch:port=match.group(0).removeprefix(':')try:int(port)exceptValueError:_debug("nonnumeric port: '%s'",port)returnNoneelse:port=DEFAULT_HTTP_PORTreturnport

I've also added the tests.

cc@picnixz . Looking forward to your review, thank you for your time and effort in advance.


📚 Documentation preview 📚:https://cpython-previews--136076.org.readthedocs.build/

@LamentXU123
Copy link
ContributorAuthor

LamentXU123 commentedJun 28, 2025
edited
Loading

Sorry for trying to merge the wrong branch. I'm fixing it.

Done now, sorry for the noise.

@@ -0,0 +1 @@
:mod:`http.cookiejar` Fix the bug happens when trying to prase ports of a IPv6 address in:class:`~http.cookiejar.DefaultCookiePolicy`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
:mod:`http.cookiejar` Fixthe bughappens when trying to prase ports of a IPv6 address in:class:`~http.cookiejar.DefaultCookiePolicy`
:mod:`http.cookiejar`: Fixa bugthat occurs when:class:`~http.cookiejar.DefaultCookiePolicy`
attempts to parse the port of an IPv6 address.

Little grammar/rewording suggestion

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@LamentXU123@StanFromIreland@picnixz

[8]ページ先頭

©2009-2025 Movatter.jp