Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-135993: Fix IPv6 bug inset_ok_port
andreturn_ok_port
#136076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
LamentXU123 wants to merge12 commits intopython:mainChoose a base branch fromLamentXU123:Fix-IPv6-bug-in-set&return-port-ok
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
gh-135993: Fix IPv6 bug inset_ok_port
andreturn_ok_port
#136076
LamentXU123 wants to merge12 commits intopython:mainfromLamentXU123:Fix-IPv6-bug-in-set&return-port-ok
+57 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
ContributorAuthor
LamentXU123 commentedJun 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sorry for trying to merge the wrong branch. I'm fixing it. Done now, sorry for the noise. |
@@ -0,0 +1 @@ | |||
:mod:`http.cookiejar` Fix the bug happens when trying to prase ports of a IPv6 address in:class:`~http.cookiejar.DefaultCookiePolicy` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
:mod:`http.cookiejar` Fixthe bughappens when trying to prase ports of a IPv6 address in:class:`~http.cookiejar.DefaultCookiePolicy` | |
:mod:`http.cookiejar`: Fixa bugthat occurs when:class:`~http.cookiejar.DefaultCookiePolicy` | |
attempts to parse the port of an IPv6 address. |
Little grammar/rewording suggestion
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Yet another IPv6 bug fix.
Instead of using the helper functions here, I've found a regex in the code, it looks like this:
This could perfectly solve the bug. caz currently, we are doing this:
And the problem is if the input is IPv6 addr like
[::1]:1234
, the program will treat:1]:1234
as a port and raise a ValueError when trying toint()
it.Now, since we've got the regex, we could use it directly in this func to make sure that port numberscan only be numbers and fix the bug.
Something like this:
I've also added the tests.
cc@picnixz . Looking forward to your review, thank you for your time and effort in advance.
📚 Documentation preview 📚:https://cpython-previews--136076.org.readthedocs.build/