Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
gh-136053: Memory Safety Issue in marshal.c TYPE_SLICE Case#136054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 18 commits intopython:mainfromakshat62:gh-136053/memory-saferty-TYPE_SLICEJun 29, 2025
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
18 commits Select commitHold shift + click to select a range
249565f
gh-136053: Memory Safety Issue in marshal.c TYPE_SLICE Case
akshat627c95d8f
📜🤖 Added by blurb_it.
blurb-it[bot]818304a
📜🤖 Added by blurb_it.
blurb-it[bot]26d50fd
📜🤖 Added by blurb_it.
blurb-it[bot]42edbea
Incorporating review comments
akshat6223f29c2
Removing unnecessary rst
akshat625c654a3
Removing extra line
akshat62fca624c
📜🤖 Added by blurb_it.
blurb-it[bot]9d500c3
📜🤖 Added by blurb_it.
blurb-it[bot]b17d057
Removing unnecessary rst
akshat62386d087
Removing unnecessary rst
akshat6217aadcb
Incorporating review comments
akshat629aa277b
Moving up condition
akshat628e1804d
Moving up condition
akshat624a744bb
PoC: Adding test case
akshat62cb246df
Removing test
akshat62dbf6ca3
Merge branch 'main' into gh-136053/memory-saferty-TYPE_SLICE
akshat625ec306e
Merge branch 'main' into gh-136053/memory-saferty-TYPE_SLICE
akshat62File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Incorporating review comments
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit17aadcb9c47a8980ab164a5abac1994eadcdd456
There are no files selected for viewing
2 changes: 1 addition & 1 deletionPython/marshal.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1659,7 +1659,6 @@ r_object(RFILE *p) | ||
PyObject *stop = NULL; | ||
PyObject *step = NULL; | ||
PyObject *start = NULL; | ||
if (idx < 0) { | ||
akshat62 marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
break; | ||
} | ||
@@ -1676,6 +1675,7 @@ r_object(RFILE *p) | ||
goto cleanup; | ||
} | ||
retval = PySlice_New(start, stop, step); | ||
r_ref_insert(retval, idx, flag, p); | ||
cleanup: | ||
Py_XDECREF(start); | ||
Py_XDECREF(stop); | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.