Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork32.2k
Star67.7k

gh-135909: Assert incoming refcnt != 0 for the free threaded GC.#136009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

andrewreds wants to merge1 commit intopython:main

base:main

Choose a base branch

fromandrewreds:gc_zero_refcount_check

Open

gh-135909: Assert incoming refcnt != 0 for the free threaded GC.#136009

andrewreds wants to merge1 commit intopython:mainfromandrewreds:gc_zero_refcount_check

Conversation

andrewreds

Copy link

andrewreds commentedJun 27, 2025•
edited by bedevere-appbot
Loading

This is to catch out double deallocation bugs. Likely from a faulty .tp_dealloc allowing the GC to run before the object is untracked.

This assert matches the one added to the GIL build, in780c497. The call to validate_refcounts was moved up to start of the GC because queue_untracked_obj_decref() creates it own zero reference count garbage.

Issue:Free threaded builds can double dealloc if .tp_dealloc sleeps #135909

@andrewreds

pythongh-135909: Assert incoming refcnt != 0 for the free threaded GC.

0882016

This is to catch out double deallocation bugs. Likely from a faulty.tp_dealloc allowing the GC to run before the object is untracked.This assert matches the one added to the GIL build, in780c497. The call to validate_refcountswas moved up to start of the GC because queue_untracked_obj_decref()creates it own zero reference count garbage.

@python-cla-bot

Copy link

python-cla-botbot commentedJun 27, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

@bedevere-app

bedevere-appbot added the awaiting review label

@bedevere-app

Copy link

bedevere-appbot commentedJun 27, 2025

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app

bedevere-appbot mentioned this pull request

Free threaded builds can double dealloc if .tp_dealloc sleeps#135909

Open

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

awaiting review

1 participant

@andrewreds

[8]ページ先頭

©2009-2025 Movatter.jp