Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-135995: Fix missing char in palmos encoding#135990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
terryjreedy merged 6 commits intopython:mainfromnkorth:patch-1
Jun 26, 2025

Conversation

nkorth
Copy link
Contributor

@nkorthnkorth commentedJun 26, 2025•
edited by bedevere-appbot
Loading

0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›. You can see the correct glyphs in this screenshot of Palm OS 3.5, or onthis page:

cloudpilot-emu github io_app_ (8)

0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›.
@python-cla-bot
Copy link

python-cla-botbot commentedJun 26, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@StanFromIreland
Copy link
Member

Hello!

It is very interesting to see someone using PalmOS! IIRC the last release was years ago.

You need to sign the CLA to allow us to merge your pr.

I'm not quite sure what to label this, I guess it could just be skip-news/issue and I'm curious as to what Benedikt will pick.

nkorth reacted with thumbs up emoji

@brianschubert
Copy link
Member

Thanks for the PR! This is a user-facing change, so an issue and news entry would be appropriate. I'd recommend opening a new issue with what you wrote here --#106326 is somewhat different. You can refer tohttps://devguide.python.org/getting-started/pull-request-lifecycle/ for more info

@ZeroIntensity
Copy link
Member

I'm not Benedikt, but this looks like it needs both an issue and news entry. We probably also want a test case.

StanFromIreland reacted with thumbs up emoji

@nkorth
Copy link
ContributorAuthor

Will do.

@nkorthnkorth changed the titleFix missing char in palmos encodinggh-135995: Fix missing char in palmos encodingJun 26, 2025
…PrDCt.rstCo-authored-by: Brian Schubert <brianm.schubert@gmail.com>
…PrDCt.rstCo-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@terryjreedy
Copy link
Member

The current encodings also maps 0x9d and 0x9e to ''. The chart shows a diagonal line an gamma-like loop, both with arrows? at the lower left. Should this be fixed also, or are these too far from any unicode chars?

@ZeroIntensity I am not familiar with codec tests; what would a test look like? This is not a calculated result.

@ZeroIntensity
Copy link
Member

I misunderstood the original issue. You're right, this isn't really testable.

nkorth reacted with thumbs up emoji

@nkorth
Copy link
ContributorAuthor

nkorth commentedJun 26, 2025•
edited
Loading

The current encodings also maps 0x9d and 0x9e to ''. The chart shows a diagonal line an gamma-like loop, both with arrows? at the lower left. Should this be fixed also, or are these too far from any unicode chars?

Those are both proprietary Palm OS icons which don't exist in Unicode, so I think they're fine as-is.

(To elaborate, they should actually never appear in text data: both icons are temporarily displayed as input hints until another letter is entered. Kinda like a keyboard shortcut, but for handwriting input. The dot in the corner indicates where to start writing the symbol.)

@ZeroIntensityZeroIntensity added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJun 26, 2025
Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Given the last two comments, I will merge after retest from blurb change.

@terryjreedyterryjreedy self-assigned thisJun 26, 2025
@terryjreedyterryjreedy merged commit58a42de intopython:mainJun 26, 2025
43 of 44 checks passed
@miss-islington-app
Copy link

Thanks@nkorth for the PR, and@terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 26, 2025
0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›.---------(cherry picked from commit58a42de)Co-authored-by: Nathan Korth <nkorth@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app
Copy link

GH-136001 is a backport of this pull request to the3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 26, 2025
0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›.---------(cherry picked from commit58a42de)Co-authored-by: Nathan Korth <nkorth@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJun 26, 2025
@bedevere-app
Copy link

GH-136002 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJun 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@brianschubertbrianschubertbrianschubert left review comments

@terryjreedyterryjreedyterryjreedy left review comments

@sjoerdmullendersjoerdmullenderAwaiting requested review from sjoerdmullender

Assignees

@terryjreedyterryjreedy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@nkorth@StanFromIreland@brianschubert@ZeroIntensity@terryjreedy
[8]ページ先頭
©2009-2025 Movatter.jp