Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-135862: fix asyncio socket partial writes of non-1d-binary arrays#135974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
duaneg wants to merge3 commits intopython:mainChoose a base branch fromduaneg:gh-135862
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…rraysThe :mod:`asyncio` code is writing binary data to a :class:`socket.socket`, andadvancing through the buffer after a partial write by doing``memoryview(data)[n:]``, where ``n`` is the number of bytes written.This assumes the :class:`memoryview` is a one dimensional buffer of bytes,which is not the case e.g. for a :class:`memoryview` of an :class:`array.array`of non-bytes, or an ``ndarray`` with more than one dimension. Partial writes ofsuch :class:`memoryview`s will corrupt the stream, repeating or omitting somedata.When creating a :class:`memoryview` from a :class:`memoryview`, first convertit to a one-dimensional array of bytes before taking the remaining slice, thusavoiding these issues.Add an assertion that the remaining data is bytes, to guard against possibleregressions if additional types of data are allowed in the future.
Hopefully this will fix the windows compile failures...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The
asyncio
code is writing binary data to asocket.socket
, and advancing through the buffer after a partial write by doingmemoryview(data)[n:]
, wheren
is the number of bytes written.This assumes the
memoryview
is a one dimensional buffer of bytes, which is not the case e.g. for amemoryview
of anarray.array
of non-bytes, or anndarray
with more than one dimension. Partial writes of suchmemoryview
s will corrupt the stream, repeating or omitting some data.When creating a
memoryview
from amemoryview
, first convert it to a one-dimensional array of bytes before taking the remaining slice, thus avoiding these issues.Add an assertion that the remaining data is bytes, to guard against possible regressions if additional types of data are allowed in the future.