Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-53203: Fix strptime() for %c, %x and %X formats on some locales#135971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:strptime-calc-alt-digitsJun 27, 2025
Merged
gh-53203: Fix strptime() for %c, %x and %X formats on some locales#135971
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:strptime-calc-alt-digitsJun 27, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* %c and %x formats on locales byn_ER, wal_ET and lzh_TW* %X format on locales ar_SA, bg_BG and lzh_TWPrepare code to use nl_langinfo().
@kulikjak, could you please test this PR on Solaris? |
Sure, I tested the change and the test passes. We do not have those three letter locales, but both 'ar_SA' and 'bg_BG' are green. Thanks for the ping! |
07183eb intopython:main 46 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 27, 2025
…les (pythonGH-135971)* Add detection of decimal non-ASCII alt digits.* Add support of non-decimal alt digits on locale lzh_TW.* Accept only numbers in correct range if alt digits are known.* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.* Fix support of single-digit hour on locales ar_SA and bg_BG.* Add support for %T, %R, %r, %C, %OC.* Prepare code to use nl_langinfo().(cherry picked from commit07183eb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 27, 2025
…les (pythonGH-135971)* Add detection of decimal non-ASCII alt digits.* Add support of non-decimal alt digits on locale lzh_TW.* Accept only numbers in correct range if alt digits are known.* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.* Fix support of single-digit hour on locales ar_SA and bg_BG.* Add support for %T, %R, %r, %C, %OC.* Prepare code to use nl_langinfo().(cherry picked from commit07183eb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-136019 is a backport of this pull request to the3.14 branch. |
GH-136020 is a backport of this pull request to the3.13 branch. |
Thank you for testing. |
serhiy-storchaka added a commit that referenced this pull requestJun 27, 2025
…ales (GH-135971) (GH-136020)* Add detection of decimal non-ASCII alt digits.* Add support of non-decimal alt digits on locale lzh_TW.* Accept only numbers in correct range if alt digits are known.* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.* Fix support of single-digit hour on locales ar_SA and bg_BG.* Add support for %T, %R, %r, %C, %OC.* Prepare code to use nl_langinfo().(cherry picked from commit07183eb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestJun 27, 2025
…ales (GH-135971) (GH-136019)* Add detection of decimal non-ASCII alt digits.* Add support of non-decimal alt digits on locale lzh_TW.* Accept only numbers in correct range if alt digits are known.* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.* Fix support of single-digit hour on locales ar_SA and bg_BG.* Add support for %T, %R, %r, %C, %OC.* Prepare code to use nl_langinfo().(cherry picked from commit07183eb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.