Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-135968: Add iOS binary stubs for strip#135970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -0,0 +1,2 @@ | |||
| #!/bin/sh | |||
| xcrun --sdk iphonesimulator${IOS_SDK_VERSION} strip -arch arm64"$@" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The return value from xcrun / the underlying command isn't returned to the caller for these as written. Either-e option (errexit) to/bin/sh and/or usingexec to run the subcommand should resolve; not sure which is best practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@cmaloney Are you sure about that? From my testing:
$ iOS/Resources/bin/arm64-apple-ios-simulator-clang -c hello.c -o hello$ echo $?0$ iOS/Resources/bin/arm64-apple-ios-simulator-clangclang: error: no input files$ echo $?1Or am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
set -e or equivalent would only be needed if there were another command following thexcrun, no? Otherwise, the stub script will exit with the status of the last executed command, that is, the command executed byxcrun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
0c6c09b intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Adds iOS binary stubs for invoking `strip`(cherry picked from commit0c6c09b)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Adds iOS binary stubs for invoking `strip`(cherry picked from commit0c6c09b)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
GH-136014 is a backport of this pull request to the3.14 branch. |
GH-136015 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.
Adds iOS binary stubs for strip.
This is something that came up in the development of a port of
numpy; Meson looks forstripby default, and raises a warning if it can't be found. It's easy enough to provide the stub to avoid the warning.strip#135968