Jun 25, 2025 · Jun 25, 2025 · Jun 25, 2025 · Jun 25, 2025 · Jun 25, 2025 · Jun 25, 2025
diff --git a/Doc/c-api/function.rst b/Doc/c-api/function.rst
   do not do type checking. Passing anything other than an instance of
   :c:data:`PyFunction_Type` is undefined behavior.

 .. c:function:: PyObject *PyFunction_GET_BUILTINS(PyObject *op)

   Return the dictionary used to look up builtins (which might be ``NULL``)
   when calling function *op*.

   This function cannot fail and does not do error checking; passing anything
   other than an instance of :c:data:`PyFunction_Type` is undefined behavior.
   There is no ``PyFunction_Get*`` equivalent for this function.

   .. versionadded 3.14

 .. c:function:: int PyFunction_AddWatcher(PyFunction_WatchCallback callback)

diff --git a/Doc/data/refcounts.dat b/Doc/data/refcounts.dat
 PyFunction_GET_ANNOTATIONS:PyObject*::0:
 PyFunction_GET_ANNOTATIONS:PyObject*:op:0:

 PyFunction_GET_BUILTINS:PyObject*::0:
 PyFunction_GET_BUILTINS:PyObject*:op:0:

 PyFunction_GetClosure:PyObject*::0:
 PyFunction_GetClosure:PyObject*:op:0:
Original file line number	Diff line number	Diff line change
Expand Up		@@ -142,6 +142,16 @@ There are a few functions specific to Python functions.
		do not do type checking. Passing anything other than an instance of
		:c:data:`PyFunction_Type` is undefined behavior.

		.. c:function:: PyObject PyFunction_GET_BUILTINS(PyObject op)

		Return the dictionary used to look up builtins (which might be ``NULL``)
		when calling function op.

		This function cannot fail and does not do error checking; passing anything
		other than an instance of :c:data:`PyFunction_Type` is undefined behavior.
		There is no ``PyFunction_Get*`` equivalent for this function.
Comment on lines +150 to +152 Copy link Member encukouJun 25, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Hm, I don't think C API WG would approve. Should this function be in a private header (and with an underscore) instead? It looks untested as well. ericsnowcurrently reacted with thumbs up emoji Copy link MemberAuthor ZeroIntensityJun 25, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It'ssort of tested. I'm not opposed to making it private. Copy link Member encukouJun 25, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. That looks like it's used in a test -- the test assumes that it's working? Yeah, the more I look into it, the better making it private seems. cc@ericsnowcurrently, who added`PyFunction_GET_BUILTINS` in#133128 Copy link MemberAuthor ZeroIntensityJun 25, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I'll put up an alternate PR. Copy link Member ericsnowcurrentlyJun 25, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. FWIW, I agree with making it internal-only.

		.. versionadded 3.14

		.. c:function:: int PyFunction_AddWatcher(PyFunction_WatchCallback callback)

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -966,6 +966,9 @@ PyFunction_GetAnnotations:PyObject*:op:0:
		PyFunction_GET_ANNOTATIONS:PyObject*::0:
		PyFunction_GET_ANNOTATIONS:PyObject*:op:0:

		PyFunction_GET_BUILTINS:PyObject*::0:
		PyFunction_GET_BUILTINS:PyObject*:op:0:

		PyFunction_GetClosure:PyObject*::0:
		PyFunction_GetClosure:PyObject*:op:0:

Expand Down