Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-134584: Eliminate redundant refcounting from _STORE_SUBSCR_LIST_INT#135907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just 2 comments.
| DEAD(sub_st); | ||
| ss = sub_st; | ||
| PyStackRef_CLOSE(list_st); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should go on the stack too, and become a normal POP_TOP.
| @@ -567,6 +567,13 @@ dummy_func(void) { | |||
| value=PyJitRef_Borrow(sym_new_const(ctx,ptr)); | |||
| } | |||
| op(_POP_TOP_INT, (value-- )) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please move this below _POP_TOP. Thanks!
Uh oh!
There was an error while loading.Please reload this page.