Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134531: useEVP_MAC API for_hashlib.HMAC#135235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
picnixz wants to merge44 commits intopython:main
base:main
Choose a base branch
Loading
frompicnixz:feat/hashopenssl/refactoring-134531

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedJun 7, 2025•
edited
Loading

Just a draft PR for the CI. I'll split the PR tomorrow. Some parts are part of#135234.

This is based on top of#135250 and#135254 so it's a bit messy.

@picnixz
Copy link
MemberAuthor

!buildbot FIPS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@picnixz for commitc444180 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135235%2Fmerge

The command will test the builders whose names match following regular expression:FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

Copy link
MemberAuthor

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall, there is also something I wanted to investigate, namely "is it faster to use SN_* names or LN_* names for OpenSSL" and whether it's better to cache the NID (as it's only used in__repr__ or.name) or directly cache aconst char *.

I'll need more experiments for this one but this also applies to the existing code where we work with EVP_MD objects instead of caching their properties.

…/evp-mac-134531# Conflicts:#Modules/_hashopenssl.c
@picnixzpicnixz changed the titlegh-134531: [PoC] allow to use EVP_MAC APIgh-134531: useEVP_MAC API for_hashlib.HMACJun 9, 2025
@picnixzpicnixz marked this pull request as ready for reviewJune 9, 2025 09:34
@picnixzpicnixz requested a review fromgpshead as acode ownerJune 9, 2025 09:34
@pythonpython deleted a comment frombedevere-botJun 9, 2025
@picnixz
Copy link
MemberAuthor

!buildbot FIPS only

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@picnixz for commit2307154 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135235%2Fmerge

The command will test the builders whose names match following regular expression:FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

@picnixzpicnixz requested a review fromqmuntalJune 9, 2025 14:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

@qmuntalqmuntalAwaiting requested review from qmuntal

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@picnixz@bedevere-bot@qmuntal
[8]ページ先頭
©2009-2025 Movatter.jp