NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.4k

[3.14] gh-135099: Only wait on`_PyOS_SigintEvent()` in main thread (GH-135100)#135116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 1 commit intopython:3.14frommiss-islington:backport-cc581f3-3.14

Jun 4, 2025

Merged

[3.14] gh-135099: Only wait on`_PyOS_SigintEvent()` in main thread (GH-135100)#135116

colesbury merged 1 commit intopython:3.14frommiss-islington:backport-cc581f3-3.14

Jun 4, 2025

Conversation

Copy link

Contributor

miss-islington commentedJun 4, 2025•
edited by bedevere-appbot
Loading

On Windows, the_PyOS_SigintEvent() event handle is used to interrupt
the main thread when Ctrl-C is pressed. Previously, we also waited on
the event from other threads, but ignored the result. However, this can
race with interpreter shutdown because the main thread closes the handle
in_PySignal_Fini and threads may still be running and using mutexes
during interpreter shtudown.

Only use_PyOS_SigintEvent() in the main thread in parking_lot.c, like
we do in other places in the CPython codebase.
(cherry picked from commitcc581f3)

Co-authored-by: Sam Grosscolesbury@gmail.com

Issue:PyMutex failure inparking_lot.c on Windows during interpreter shutdown #135099

pythongh-135099: Only wait on_PyOS_SigintEvent()in main thread (p…

c46a14c

…ythonGH-135100)On Windows, the `_PyOS_SigintEvent()` event handle is used to interruptthe main thread when Ctrl-C is pressed. Previously, we also waited onthe event from other threads, but ignored the result. However, this canrace with interpreter shutdown because the main thread closes the handlein `_PySignal_Fini` and threads may still be running and using mutexesduring interpreter shtudown.Only use `_PyOS_SigintEvent()` in the main thread in parking_lot.c, likewe do in other places in the CPython codebase.(cherry picked from commitcc581f3)Co-authored-by: Sam Gross <colesbury@gmail.com>