Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-135101: When choosing the default simulator device, don't usesimctl --set testing#135102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
python-cla-botbot commentedJun 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
!buildbot iOS |
bedevere-bot commentedJun 4, 2025
🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commitd07659e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135102%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My testing suggests this will work as intended; thanks for the report and fix!
| @@ -127,7 +127,7 @@ async def async_check_output(*args, **kwargs): | |||
| async def select_simulator_device(): | |||
| # List the testing simulators, in JSON format | |||
freakboy3742Jun 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| # List the testing simulators, in JSON format | |
| # List the testing simulators, in JSON format. Use the full list, not just | |
| # the testing set; on a fresh install (or in CI), the testing set may be empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Dangit... forgot to merge this suggestion. I've got some other cleanups I need to make in the general area; I'll add it in then.
dba9de7 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@joerick for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…e `simctl --set testing` (pythonGH-135102)On a fresh Xcode install (including some CI provider configurations), there isno pre-existing testing set that can be used to identify simulator models. Usethe default device set to detect available models instead. Live testingsimulators are still created in the testing set.(cherry picked from commitdba9de7)Co-authored-by: Joe Rickerby <joerick@mac.com>
GH-135113 is a backport of this pull request to the3.14 branch. |
…e `simctl --set testing` (pythonGH-135102)On a fresh Xcode install (including some CI provider configurations), there isno pre-existing testing set that can be used to identify simulator models. Usethe default device set to detect available models instead. Live testingsimulators are still created in the testing set.(cherry picked from commitdba9de7)Co-authored-by: Joe Rickerby <joerick@mac.com>
GH-135114 is a backport of this pull request to the3.13 branch. |
…se `simctl --set testing` (GH-135102) (#135114)On a fresh Xcode install (including some CI provider configurations), there isno pre-existing testing set that can be used to identify simulator models. Usethe default device set to detect available models instead. Live testingsimulators are still created in the testing set.(cherry picked from commitdba9de7)Co-authored-by: Joe Rickerby <joerick@mac.com>
…se `simctl --set testing` (GH-135102) (#135113)On a fresh Xcode install (including some CI provider configurations), there isno pre-existing testing set that can be used to identify simulator models. Usethe default device set to detect available models instead. Live testingsimulators are still created in the testing set.(cherry picked from commitdba9de7)Co-authored-by: Joe Rickerby <joerick@mac.com>
…on't use `simctl --set testing` (pythonGH-135102) (python#135113)On a fresh Xcode install (including some CI provider configurations), there isno pre-existing testing set that can be used to identify simulator models. Usethe default device set to detect available models instead. Live testingsimulators are still created in the testing set.(cherry picked from commitdba9de7)Co-authored-by: Joe Rickerby <joerick@mac.com>
…on't use `simctl --set testing` (pythonGH-135102) (python#135114)On a fresh Xcode install (including some CI provider configurations), there isno pre-existing testing set that can be used to identify simulator models. Usethe default device set to detect available models instead. Live testingsimulators are still created in the testing set.(cherry picked from commitdba9de7)Co-authored-by: Joe Rickerby <joerick@mac.com>
Uh oh!
There was an error while loading.Please reload this page.
This is a fix for the error seen inpypa/cibuildwheel#2443 .
I don't know what
--set testingis doing, but the previous default deviceiPhone SE (3rd edition)was not listed there either, and omitting the flag seems to list all the devices that the SDK knows about, rather than ones previously used for testing.cc@freakboy3742