Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-135069: Fix exception message in encodings.idna module#135071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
danielhollas wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromdanielhollas:encodings-fix-fstring

Conversation

danielhollas
Copy link
Contributor

@danielhollasdanielhollas commentedJun 3, 2025•
edited by bedevere-appbot
Loading

Fix the 'Unsupported error handling' error messagein the encodings.idna.IncrementalDecoder class.
@danielhollas
Copy link
ContributorAuthor

danielhollas commentedJun 3, 2025•
edited
Loading

The docs build fails with

cpython/cpython/Doc/build/NEWS:91: WARNING: py:meth reference target not found: encodings.idna.IncrementalDecoder.decode [ref.meth]

Thedecode method comes from a parent class I believe. Should a link to the private_buffer_decode method instead?

@tomasr8
Copy link
Member

Should a link to the private _buffer_decode method instead?

You could also just link toIncrementalDecoder

@danielhollas
Copy link
ContributorAuthor

danielhollas commentedJun 3, 2025•
edited
Loading

You could also just link to IncrementalDecoder

Thanks, makes sense to me. I tried to change it but still got an error:

cpython/Doc/build/NEWS:91: WARNING: py:class reference target not found: encodings.idna.IncrementalDecoder [ref.class]

No matter how long I stare at it the new blurb looks correct to me? Apologies if that is something obvious, I don't have much experience with rst.

EDIT: The windows build failure looks like a transient http error?

@tomasr8
Copy link
Member

Maybe we can suppress the reference with!? Something like

 `:class:`!encodings.idna.IncrementalDecoder

@danielhollas
Copy link
ContributorAuthor

Maybe we can suppress the reference with !?

That worked, thanks!

tomasr8 reacted with thumbs up emoji

Copy link
Member

@tomasr8tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks! The news entry could be even shorter (and with less detail) but I think this is also fine 🙂

danielhollas reacted with thumbs up emojidanielhollas reacted with heart emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tomasr8tomasr8tomasr8 approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees
No one assigned
Labels
awaiting core reviewneeds backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encodings.idna: Unexpanded f-string in "Unsupported error handling" exception
3 participants
@danielhollas@tomasr8@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp