Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-134953: Expand theming forTrue/False/None#135000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| @@ -176,6 +176,7 @@ class Argparse(ThemeSection): | |||
| class Syntax(ThemeSection): | |||
| prompt: str = ANSIColors.BOLD_MAGENTA | |||
| keyword: str = ANSIColors.BOLD_BLUE | |||
| keyword_constant: str = ANSIColors.BOLD_BLUE | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
And so the question is, do we want to change this for pyrepl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree with the issue OP that theis None in particular being in the same color looks strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It could default toANSIColors.CYAN, sinceTrue,False, andNone would then be the same color as all the built-ins.
| @@ -0,0 +1,2 @@ | |||
| Expand ``_colorize`` theme with ``keyword_colorize`` and implement in | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thinkkeyword_colorize was meant to bekeyword_constant here.
Uh oh!
There was an error while loading.Please reload this page.
I am not a fan of
constant, but it seems to be what Pypygments and Magicpython uses so I guess it is best?As for the other parts of the proposal in the issue I am not as big a fan, but I think this one is fine, and something I myself am used to in editors.