Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132983: Minor fixes and clean up for the _zstd module#134930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 9 commits intopython:mainfromserhiy-storchaka:zstd-fixes
Jun 1, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedMay 30, 2025•
edited by bedevere-appbot
Loading

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One question and one concern, but the rest looks good! Thank you for the improvements :)

Comment on lines -510 to -515
if (!PyType_Check(c_parameter_type) || !PyType_Check(d_parameter_type)) {
PyErr_SetString(PyExc_ValueError,
"The two arguments should be CompressionParameter and "
"DecompressionParameter types.");
return NULL;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sanity check on removing the type checks here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The type checks are already handled by argument clinic, so these are actually redundant.

serhiy-storchaka reacted with thumbs up emoji
Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The changes look good! One minor wording suggestion but great otherwise. Thank you!

serhiy-storchakaand others added2 commitsJune 1, 2025 09:04
Co-authored-by: Emma Smith <emma@emmatyping.dev>
@serhiy-storchakaserhiy-storchaka merged commitb595237 intopython:mainJun 1, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 1, 2025
…nGH-134930)(cherry picked from commitb595237)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-134998 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJun 1, 2025
@serhiy-storchaka
Copy link
MemberAuthor

Thank you@AA-Turner and@emmatyping for your review.

emmatyping reacted with heart emoji

@serhiy-storchakaserhiy-storchaka deleted the zstd-fixes branchJune 1, 2025 08:23
serhiy-storchaka added a commit that referenced this pull requestJun 1, 2025
…34930) (GH-134998)(cherry picked from commitb595237)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

@emmatypingemmatypingemmatyping approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@serhiy-storchaka@AA-Turner@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp