Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-134248 test_getallocatedblocks pre-check to ignore immortalized strings#134871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

tpburns wants to merge1 commit intopython:main

base:main

Choose a base branch

fromtpburns:getallocatedblocksTestCorrection

Open

gh-134248 test_getallocatedblocks pre-check to ignore immortalized strings#134871

tpburns wants to merge1 commit intopython:mainfromtpburns:getallocatedblocksTestCorrection

+6 −17

Conversation

tpburns

Copy link

tpburns commentedMay 29, 2025•
edited
Loading

When sanity checking againstgettotalrefcount we exclude the blocks for immortalized strings since their references are not tracked/reported. This now matchesrefleak.py's book-keeping using the same functions.

This will avoid the test dependency failures seen inPython 3.15.0: test_sys.test_getallocatedblocks() fails if run after test_collections.test_odd_sizes() #134248.
It seems to no longer have issues for free threading builds as well (and I did observe failures locally when the check was ran but didn't subtract the immortalized count). But, I don't know enough to claim it's actually solving the issue from the code comment inMake the specializing interpreter thread-safe in--disable-gil builds #115999.
It may or may not solve the ios CI failure seen intest_sys.SysModuleTest.get_allocated_blocks test precondition intermittently fails on iOS #130384, I would appreciate guidance on how testing that would work.

As such, the current state of the PR is that the check is never skipped - to be be adjusted as needed given CI results and/or feedback.

Issue:Python 3.15.0: test_sys.test_getallocatedblocks() fails if run after test_collections.test_odd_sizes() #134248

@tpburns

pythongh-134248test_getallocatedblocks pre-check to ignore immortali…

5a193f9

…zed stringsWhen sanity checking against gettotalrefcount we exclude the blocks forimmortalized strings since their references are not tracked/reported. Thisnow matches refleak.py's book-keeping using the same functions.

@python-cla-bot

Copy link

python-cla-botbot commentedMay 29, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

@bedevere-app

bedevere-appbot mentioned this pull request

Python 3.15.0: test_sys.test_getallocatedblocks() fails if run after test_collections.test_odd_sizes()#134248

Open

@bedevere-app

bedevere-appbot added awaiting review testsTests in the Lib/test dir labels

@bedevere-app

Copy link

bedevere-appbot commentedMay 29, 2025

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@ZeroIntensity

ZeroIntensity added the skip news label

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

awaiting review skip news tests

Tests in the Lib/test dir

2 participants

@tpburns

@ZeroIntensity

[8]ページ先頭

©2009-2025 Movatter.jp