Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

(gh-134817) Documents [Timed]RotatingFileHandler shouldRollover method#134818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vsajip merged 1 commit intopython:mainfromAllenSH12:docs/rotating-file-handlers
May 28, 2025

Conversation

AllenSH12
Copy link
Contributor

@AllenSH12AllenSH12 commentedMay 28, 2025•
edited by github-actionsbot
Loading

@AllenSH12AllenSH12 requested a review fromvsajip as acode ownerMay 28, 2025 00:55
@python-cla-bot
Copy link

python-cla-botbot commentedMay 28, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@AllenSH12AllenSH12force-pushed thedocs/rotating-file-handlers branch from3cbc934 to3d696dbCompareMay 28, 2025 00:58
@AllenSH12AllenSH12 changed the title(gh-134817) Documents RotatingFileHandler and TimedRotatingFileHandler shouldRoll…(gh-134817) Documents [Timed]RotatingFileHandler shouldRollover methodMay 28, 2025
@vsajipvsajip merged commit7be5916 intopython:mainMay 28, 2025
28 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMay 28, 2025
@vsajipvsajip added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 28, 2025
@miss-islington-app
Copy link

Thanks@AllenSH12 for the PR, and@vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@AllenSH12 for the PR, and@vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 28, 2025
…ethod (pythonGH-134818)(cherry picked from commit7be5916)Co-authored-by: Allen Hernandez <AllenSH12@users.noreply.github.com>Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 28, 2025
…ethod (pythonGH-134818)(cherry picked from commit7be5916)Co-authored-by: Allen Hernandez <AllenSH12@users.noreply.github.com>Co-authored-by: Allen Hernandez <2349718+AllenSH12@users.noreply.github.com>
@bedevere-app
Copy link

GH-134823 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 28, 2025
@bedevere-app
Copy link

GH-134824 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 28, 2025
@vsajip
Copy link
Member

@AllenSH12 Thanks for the patch - for some reason, the backport PRs don't appear to have registered your signature of the CLA (perhaps it relates to your email address). Could you please sign again so that the PRs for 3.13 and 3.14 can be merged? Thanks!

vsajip pushed a commit that referenced this pull requestMay 28, 2025
vsajip pushed a commit that referenced this pull requestMay 28, 2025
@AllenSH12
Copy link
ContributorAuthor

You're welcome@vsajip

I see the backporting PRs have been merged now, guessing everything is good with the CLA?

@vsajip
Copy link
Member

Yes, I'd set them up to auto-merge once the block was removed, which you did by signing again, I guess 😄

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vsajipvsajipvsajip approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@AllenSH12@vsajip
[8]ページ先頭
©2009-2025 Movatter.jp