Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132775: Always Set __builtins__ In _PyFunction_FromXIData()#134758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedMay 26, 2025•
edited by bedevere-appbot
Loading

This is a small follow-up togh-133481. There's a corner case in the behavior ofPyImport_ImportModuleAttrString() where it expects__builtins__ to be set if__globals__ is set.

@ericsnowcurrentlyericsnowcurrentlyenabled auto-merge (squash)May 27, 2025 15:17
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Might as well throw a checkmark on here :)

@ericsnowcurrentlyericsnowcurrently merged commit9b5e800 intopython:mainMay 27, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 27, 2025
…ythongh-134758)This is a small follow-up topythongh-133481.  There's a corner casein the behavior of PyImport_ImportModuleAttrString(), whereit expects __builtins__ to be set if __globals__ is set.(cherry picked from commit9b5e800)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-app
Copy link

GH-134794 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 27, 2025
@ericsnowcurrentlyericsnowcurrently deleted the fix-missing-builtins branchMay 27, 2025 15:47
ericsnowcurrently added a commit that referenced this pull requestMay 27, 2025
…gh-134794)This is a small follow-up togh-133481.  There's a corner casein the behavior of PyImport_ImportModuleAttrString(), whereit expects __builtins__ to be set if __globals__ is set.(cherry picked from commit9b5e800, AKAgh-134758)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ericsnowcurrently@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp