NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.4k

gh-134675: Add t-string prefixes to tokenizer module, lexical analysis doc, and add a test to make sure we catch this error in the future.#134734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ericvsmith merged 3 commits intopython:mainfromericvsmith:issue-134675

May 26, 2025

Merged

gh-134675: Add t-string prefixes to tokenizer module, lexical analysis doc, and add a test to make sure we catch this error in the future.#134734

ericvsmith merged 3 commits intopython:mainfromericvsmith:issue-134675

May 26, 2025

Conversation

Copy link

Member

ericvsmith commentedMay 26, 2025•
edited by bedevere-appbot
Loading

Issue:tokenize._all_string_prefixes does not list t-string prefixes #134675

Add t-string prefixes to _all_string_prefixes, and add a test to make…

81edce5

… sure we catch this error in the future.

ericvsmith requested review frompablogsal andlysnikolaou ascode owners

May 26, 2025 16:56

bedevere-appbot added the awaiting core review label

May 26, 2025

bedevere-appbot mentioned this pull request

May 26, 2025

tokenize._all_string_prefixes does not list t-string prefixes#134675

Closed

ericvsmith added 3.14

bugs and security fixes

needs backport to 3.14

bugs and security fixes

skip news labels

May 26, 2025

ericvsmithand others added2 commits

May 26, 2025 12:57

Merge branch 'main' into issue-134675

75d4513

Update lexical analysis docs for t-string prefixes.

63b767c

ericvsmith requested review fromwillingc andAA-Turner ascode owners

May 26, 2025 17:07

ericvsmith changed the title~~gh-134675: Add t-string prefixes to tokenizer module, and add a test to make sure we catch this error in the future.~~gh-134675: Add t-string prefixes to tokenizer module, lexical analysis doc, and add a test to make sure we catch this error in the future.

May 26, 2025

ericvsmith merged commit08c78e0 intopython:main

May 26, 2025

39 checks passed

Copy link

miss-islington-appbot commentedMay 26, 2025

Thanks@ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting core review label

May 26, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 26, 2025

pythongh-134675: Add t-string prefixes to tokenizer module, lexical a…

2da8555

…nalysis doc, and add a test to make sure we catch this error in the future. (pythonGH-134734)* Add t-string prefixes to _all_string_prefixes, and add a test to make sure we catch this error in the future.* Update lexical analysis docs for t-string prefixes.(cherry picked from commit08c78e0)Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>

ericvsmith deleted the issue-134675 branch

May 26, 2025 17:49

Copy link

bedevere-appbot commentedMay 26, 2025

GH-134739 is a backport of this pull request to the3.14 branch.

bedevere-appbot removed the needs backport to 3.14bugs and security fixes label

May 26, 2025

ericvsmith added a commit that referenced this pull request

May 26, 2025

[3.14]gh-134675: Add t-string prefixes to tokenizer module, lexical …

74f5667

…analysis doc, and add a test to make sure we catch this error in the future. (GH-134734) (#134739)gh-134675: Add t-string prefixes to tokenizer module, lexical analysis doc, and add a test to make sure we catch this error in the future. (GH-134734)* Add t-string prefixes to _all_string_prefixes, and add a test to make sure we catch this error in the future.* Update lexical analysis docs for t-string prefixes.(cherry picked from commit08c78e0)Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>