Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-134557: Suppress immortalization in _PyCode_GetScriptXIData under free-threading#134686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
bedevere-bot commentedMay 26, 2025
🤖 New build scheduled with the buildbot fleet by@emmatyping for commit4dac776 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134686%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again. |
Oh, the refleak buildbots won't catch any leaks because there aren't any tests that could trigger a leak. My mistake🤦♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this makes sense.
c60f39a intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@neonene for the PR, and@ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…under free-threading (pythongh-134686)Disable immortalization around Py_CompileString*().The same approach as332356b that fixed the refleaks in compile() and eval().(cherry picked from commitc60f39a)Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me.
GH-134738 is a backport of this pull request to the3.14 branch. |
Thanks for the fix,@neonene! |
… under free-threading (gh134738)Disable immortalization around Py_CompileString*().The same approach as332356b that fixed the refleaks in compile() and eval().E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me.(cherry picked from commitc60f39a, AKAgh-134686)Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
The same approach as332356b that fixed the refleaks in
compile()andeval().cc@colesbury@ericsnowcurrently@emmatyping I'm not so confident.
E:09e72cf can pass
test_capi,test_sysandtest__interpchannelswith this patch for me.