Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-130328: Fix WindowsConsoleGetEventTests after gh-133728#134660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

chris-eibl
Copy link
Member

@chris-eiblchris-eibl commentedMay 25, 2025•
edited by bedevere-appbot
Loading

Fixes the WindowsConsoleGetEventTests which got broken due to movingwait intoget_event inWindowsConsole during#133728.

@bedevere-appbedevere-appbot added awaiting review testsTests in the Lib/test dir labelsMay 25, 2025
@ambvambv changed the titlefix WindowsConsoleGetEventTests after PR-133728GH-130328: Fix WindowsConsoleGetEventTests after gh-133728May 25, 2025
@ambvambv removed the skip issue labelMay 25, 2025
@ambv
Copy link
Contributor

!buildbot Windows10

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ambv for commit7f15126 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134660%2Fmerge

The command will test the builders whose names match following regular expression:Windows10

The builders matched are:

  • AMD64 Windows10 PR

@ambv
Copy link
Contributor

Buildbot looks happy now!

chris-eibl reacted with hooray emoji

@ambvambv merged commit1000283 intopython:mainMay 25, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks@chris-eibl for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 25, 2025
pythongh-134660)(cherry picked from commit1000283)Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@bedevere-app
Copy link

GH-134666 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 25, 2025
ambv pushed a commit that referenced this pull requestMay 25, 2025
…-134660) (gh-134666)(cherry picked from commit1000283)Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@chris-eiblchris-eibl deleted the fix_WindowsConsoleGetEventTests branchMay 26, 2025 05:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees
No one assigned
Labels
awaiting reviewskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@chris-eibl@ambv@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp