Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-69605: Disable PyREPL module autocomplete fallback on regular completion#134181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

loic-simon
Copy link
Contributor

@loic-simonloic-simon commentedMay 18, 2025•
edited by bedevere-appbot
Loading

When no module completions are available, do not fallback on completions from current namespace, as there are not relevant.

Before:

>>>import pri<TAB>>>>importprint(>>>>>>from typingimport Na<TAB>>>>from typingimportNameError(

After:

>>>import pri<TAB>>>>import pri>>>>>>from typingimport Na<TAB>>>>from typingimport Na

cc@tomasr8

When no module completions are available, do not fallback to completions from current namespace
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link
Member

@tomasr8tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! Overall approach looks good, I just have some nitpicks 🙂

Copy link
Member

@tomasr8tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

loic-simon reacted with hooray emoji
@ambvambv merged commit0e3bc96 intopython:mainMay 25, 2025
47 checks passed
@ambvambv added the needs backport to 3.14bugs and security fixes labelMay 25, 2025
@miss-islington-app
Copy link

Thanks@loic-simon for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 25, 2025
…r completion (pythongh-134181)(cherry picked from commit0e3bc96)Co-authored-by: Loïc Simon <loic.pano@gmail.com>Co-authored-by: Loïc Simon <loic.simon@napta.io>
@bedevere-app
Copy link

GH-134680 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 25, 2025
ambv pushed a commit that referenced this pull requestMay 25, 2025
…ar completion (gh-134181) (gh-134680)(cherry picked from commit0e3bc96)Co-authored-by: Loïc Simon <loic.simon@napta.io>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tomasr8tomasr8tomasr8 approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@loic-simon@tomasr8@ambv
[8]ページ先頭
©2009-2025 Movatter.jp