Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.10] gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__ (GH-126503) (GH-126572)#134030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:3.10frommiss-islington:backport-aee80cd-3.10
Jun 1, 2025

Conversation

miss-islington
Copy link
Contributor

gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely onexit (GH-126503)

Ifread() in the ConnectionHandler thread raisesOSError (exceptConnectionError),
the ConnectionHandler shuts down the entire ThreadedEchoServer,
preventing further connections.
It also does that forEPROTOTYPE inwrap_conn.

As far as I can see, this is done to avoid the server thread getting stuck,
forgotten, in its accept loop. However, since 2011 (5b95eb9)
the server is used as a context manager, and its__exit__ doesstop() andjoin().
(I'm not sure if wealways usedwith since that commit, but currently we do.)

Make sure that the context manageris used, and remove theserver.stop()
calls from ConnectionHandler.
(cherry picked from commitc9cda16)

(cherry picked from commitaee80cd)

Co-authored-by: Miss Islington (bot)31488909+miss-islington@users.noreply.github.com
Co-authored-by: Petr Viktorinencukou@gmail.com

…Error in ConnectionHandler; rely on __exit__ (pythonGH-126503) (pythonGH-126572)pythongh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__ (pythonGH-126503)If `read()` in the ConnectionHandler thread raises `OSError` (except `ConnectionError`),the ConnectionHandler shuts down the entire ThreadedEchoServer,preventing further connections.It also does that for `EPROTOTYPE` in `wrap_conn`.As far as I can see, this is done to avoid the server thread getting stuck,forgotten, in its accept loop. However, since 2011 (5b95eb9)the server is used as a context manager, and its `__exit__` does `stop()` and `join()`.(I'm not sure if we *always* used `with` since that commit, but currently we do.)Make sure that the context manager *is* used, and remove the `server.stop()`calls from ConnectionHandler.(cherry picked from commitc9cda16)(cherry picked from commitaee80cd)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@encukou for commitfa8024b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134030%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 15, 2025
@ambv
Copy link
Contributor

There are more buildbot failures here than the 3.11 ones. Fedora Stable Refleaks and RHEL8 Refleaks are of particular concern.

@ambvambv requested review fromencukou and removed request fortiranMay 15, 2025 19:14
@encukou
Copy link
Member

I bet the asyncio refleak tests time out after 45 minutes becausepython/buildmaster-config#545 didn't target PR builders.
I don't think there's a good way to make this config per-branch on the PR builders, and relaxing the timeout could make the runs unreliable for the newer branches.
Should I look into making the PR bot green, or would it be OK to wait for the post-merge run?

For the other builds: Android, ios, wasi, --disable-gil & bigmem are not set up for 3.10.
The Mac NoGIL run managed build a regular Python (withconfigure: WARNING: unrecognized options: --disable-gil), and segfaults indbm tests. I'd write it off as some weird version of dbm... Do you think it's worth looking into? Either way it's not really relevanthere, and post-merge runs won't include nogil.

@ambvambv merged commitf85e71a intopython:3.10Jun 1, 2025
80 of 94 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouAwaiting requested review from encukou

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@miss-islington@bedevere-bot@ambv@encukou

[8]ページ先頭

©2009-2025 Movatter.jp