Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-132876: workaround broken ldexp() on Windows 10#133135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tim-one merged 10 commits intopython:mainfromskirpichev:fix-ldexp-MS/132876
May 26, 2025
Merged
Show file tree
Hide file tree
Changes from8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
``ldexp()`` on Windows doesn't round subnormal results before Windows 11,
but should. Python's :func:`math.ldexp` wrapper now does round them, so
results may change slightly, in rare cases of very small results, on
Windows versions before 11.
21 changes: 21 additions & 0 deletionsModules/mathmodule.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2163,6 +2163,27 @@ math_ldexp_impl(PyObject *module, double x, PyObject *i)
} else {
errno = 0;
r = ldexp(x, (int)exp);
#ifdef _MSC_VER
if (DBL_MIN > r && r > -DBL_MIN) {
/* Denormal (or zero) results can be incorrectly rounded here (rather,
truncated). Fixed in newer versions of the C runtime, included
with Windows 11. */
int original_exp;
frexp(x, &original_exp);
if (original_exp > DBL_MIN_EXP) {
/* Shift down to the smallest normal binade. No bits lost. */
int shift = DBL_MIN_EXP - original_exp;
x = ldexp(x, shift);
exp -= shift;
}
/* Multiplying by 2**exp finishes the job, and the HW will round as
appropriate. Note: if exp < -DBL_MANT_DIG, all of x is shifted
to be < 0.5ULP of smallest denorm, so should be thrown away. If
exp is so very negative that ldexp underflows to 0, that's fine;
no need to check in advance. */
r = x*ldexp(1.0, (int)exp);
}
#endif
if (isinf(r))
errno = ERANGE;
}
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp