This repository was archived by the owner on Nov 23, 2017. It is now read-only.
Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork178
Fix stop_serving in proactor loop kill all listening servers#496
Open
julien-duponchelle wants to merge1 commit intopython:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix stop_serving in proactor loop kill all listening servers#496
julien-duponchelle wants to merge1 commit intopython:masterfromjulien-duponchelle:fix_stop_serving_proactor
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Current implementation of the asyncio Proactor event loop has anissue, when you stop a server it's cancel the futures of all otherservers.
LGTM.@asvetlov can you also take a look? |
fafhrd91 commentedFeb 22, 2017
lgtm asvetlov is not very active at the moment |
I can merge this PR, but would you be able to re-submit it tohttp://github.com/python/cpython with a link to this PR? This would make merging this easier for me. |
Yes of course I will do it tomorrow.Le jeu. 2 mars 2017 à 23:14, Yury Selivanov <notifications@github.com> aécrit : … I can merge this PR, but would you be able to re-submit it tohttp://github.com/python/cpython <https://github.com/python/cpython> with a link to this PR? This would make merging this easier for me. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#496 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVFXZkNrVTmNCSK3TgLWlP-43YwozhSks5rhz8qgaJpZM4MHtGW> . |
Would you be able to do it sooner by any chance? 3.6.1 RC1 is going to be tagged tomorrow. |
PR opened:python/cpython#431 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of the asyncio Proactor event loop has an issue, when you stop a server it's cancel the futures of all other servers.