- Notifications
You must be signed in to change notification settings - Fork67
Morphotope tutorial#712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedOct 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #712 +/- ##=======================================+ Coverage 97.4% 98.3% +0.9%======================================= Files 26 26 Lines 4328 4195 -133 =======================================- Hits 4214 4123 -91+ Misses 114 72 -42 🚀 New features to boost your workflow:
|
Can we do OSM data and osmnx as we do elsewhere in the guide? Any reason to use Overture? |
u3ks commentedOct 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
the only reason was to be consistent with urban_taxonomy, but changing to osmnx shouldnt make a difference really. We'll have to drop/change the tunnel and street type filtering though |
That is fine, we don't need to be 1:1 with the paper here. The other is not either. |
I changed the data to OSM. The morphotopes use the same params as the paper and look good. The hierarchy is a bit meh, but i think its ok for a tutorial. |
The notebook has:
Anything missing ? maybe itd be good to cache the overture data, because it takes 4-5 minutes just reading it ...