Codecov Report

Attention: Patch coverage is50.45045% with55 lines in your changes missing coverage. Please review.

Project coverage is 97.4%. Comparing base(4037c70) to head(7b9c02c).
Report is 112 commits behind head on main.

@@           Coverage Diff           @@##            main    #704     +/-   ##=======================================+ Coverage   97.4%   97.4%   +0.1%=======================================  Files         26      42     +16       Lines       4328    7275   +2947     =======================================+ Hits        4214    7088   +2874- Misses       114     187     +73

• have a function thatonly transforms data structure coins>graph
• have metric computation as separate functions: in momempy, the logic is: every metric has its own function. steps: create graph > pass it to function > return metric.
• for metrics that are vanilla networkx: do NOT compute separately.
• for metrics that are derived: separate functions, if they rely on some vanilla stuff >> have it there inside the derived-metric function
• instead of "strokes_to_graph", call it "coins_to_nx". in gdf_to_nx: keyword for primal vs dual exists. in "coins_to_nx": keyword
• we do not need to return primal graph at all (anvy: make sure we can recreate -- mapping through geopandas)
• graph_to_strokes: pointless -- can be simply dropped

once api is fixed, ping martin, get thumbs up, then we can work on tests.