Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit1c9f6e7

Browse files
wberniclanton
authored andcommitted
Use Number() for more strict parameter value parsing
1 parent59ebb5f commit1c9f6e7

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

‎apps/rush-lib/src/logic/operations/OperationExecutionManager.ts‎

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -157,26 +157,28 @@ export class OperationExecutionManager {
157157
if(parallelism==='max'){
158158
this._parallelism=numberOfCores;
159159
}else{
160-
constparsed:number=parseInt(parallelism,10);
160+
constparallelismAsNumber:number=Number(parallelism);
161161

162-
letparallelismInt:number=parsed>0 ?parsed :1;
162+
constgetParallelismValueHighThanZero=(value:number)=>(value>0 ?value :1);
163163

164164
if(typeofparallelism==='string'&&parallelism.trim().endsWith('%')){
165-
if(parsed<=0||parsed>100){
165+
constparsedPercentage=Number(parallelism.trim().replace(/\%$/,''));
166+
167+
if(parsedPercentage<=0||parsedPercentage>100){
166168
thrownewError(
167169
`Invalid percentage value of '${parallelism}', value cannot be less than '0%' or more than '100%'`
168170
);
169171
}
170172

171-
constworkers:number=Math.floor((parsed/100)*numberOfCores);
172-
parallelismInt=Math.max(workers,1);
173-
}elseif(isNaN(parsed)){
174-
thrownewError(
175-
`Invalid parallelism value of '${parallelism}', expected a number, a percentage, or 'max'`
176-
);
173+
constworkers:number=Math.floor((parallelismAsNumber/100)*numberOfCores);
174+
this._parallelism=getParallelismValueHighThanZero(workers);
175+
}elseif(!isNaN(parallelismAsNumber)){
176+
this._parallelism=getParallelismValueHighThanZero(parallelismAsNumber);
177177
}
178178

179-
this._parallelism=parallelismInt;
179+
thrownewError(
180+
`Invalid parallelism value of '${parallelism}', expected a number, a percentage, or 'max'`
181+
);
180182
}
181183
}else{
182184
// If an explicit parallelism number wasn't provided, then choose a sensible

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp