- Notifications
You must be signed in to change notification settings - Fork1.2k
feat: expose Desc error through public Err() method#1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
duricanikolic wants to merge1 commit intoprometheus:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds a public Err() method to Desc type to allow users to check ifan error occurred during descriptor construction. Previously, the errorfield was private and inaccessible.🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
489f84c to5ffa5ccComparebboreham approved these changesOct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Adds a public
Err()method toDesctype to allow users to check if an error occurred during descriptor construction. Previously, the error field was private and inaccessible.Our use case is as follows:
Desc.Collect()method, we dynamically create aMetricusingNewConstMetric()to report the current value.However, if the
Descwas constructed with an error (for example, due to an invalid label name), that error remains hidden until the collector’sCollect()method is invoked for the first time.It would be much more practical if the Prometheus API exposed a method such as
Desc.Err(), which would return any error that occurred during the creation of theDesc. That's the motivation for the present PR.Signed-off-by: Yuri Nikolicdurica.nikolic@grafana.com