- Notifications
You must be signed in to change notification settings - Fork1.2k
chore(ci): Add yaml and action formatter/linter to CI#1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
kakkoyun wants to merge4 commits intoprometheus:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
kakkoyun commentedOct 24, 2025
- chore(ci): Add CRLF detection and fix targets to prevent CRLF contamination
- chore(go/fmt): Fix formatting issues
- chore(ci): Add yaml and action formatter/linter to CI
- chore(.github/workflows): Fix action formats and issues
…nationAdd two new Makefile targets to detect and fix carriage return (CRLF)line endings that can contaminate the codebase from Windows environments:- check-crlf: Scans all text files (excluding hidden dirs and vendor) for CRLF line endings and fails if any are found- fix-crlf: Automatically converts CRLF to LF using the tr commandAdd CRLF check to CI workflow to catch line ending issues early in PRs.The check runs immediately after checkout, before any other validation.Also rename go.yml to validate.yml to better reflect the workflow'spurpose, and fix job name casing (supportedVersions -> supported_versions).Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would copy the.yamllint config fromprometheus/prometheus.
| YAMLFMT :=$(FIRST_GOPATH)/bin/yamlfmt | ||
| ACTIONLINT :=$(FIRST_GOPATH)/bin/actionlint | ||
| $(YAMLFMT): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We already havecommon-yamllint inMakefile.common.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.