- Notifications
You must be signed in to change notification settings - Fork1.2k
Integer-only Counters#1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Signed-off-by: Not Rob Pike <closeup_oblique.0o@icloud.com>
indeed the ival and fval can get updated separately, but such updateis always one or the other, not both.
There are 2 lint failures. One of them exists in main already and is not due to any change in this PR. The other is introduced because the |
| ) | ||
| // 64-bit float mantissa: https://en.wikipedia.org/wiki/Double-precision_floating-point_format | ||
| varfloat64Mantissauint64=9007199254740992 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't this really be a const instead of a var? IMHO it would also be clearer and more legible if it were defined as1 << 53 rather than a long decimal number.
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Avoid rounding error for large-valued Counters.
@ArthurSens@bwplotka@kakkoyun